Exit reconstruction early #14915
Open
Exit reconstruction early #14915
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested changes
Feb 12, 2025
Comment on lines
+103
to
+107
| // If all blobs have been seen via gossip, we can exit the reconstruction | ||
| // routine early as there is nothing to fetch from the EL. | ||
| if !blobUnseen { | ||
| return | ||
| } |
There was a problem hiding this comment.
I think the commitment check is fine, but I’m not a fan of the blob unseen check since it’s already handled in ReconstructBlobSidecars:
if len(kzgHashes) == 0 {
return nil, nil
}
It feels like we’re repeating the same check.
Side note: we also can move blobExistedInDBTotal inside ReconstructBlobSidecars to not repeat the same loop
There was a problem hiding this comment.
Do you think we should move blobRecoveredFromELTotal there too ? I looked at the reconstruction metrics and it would be wierd to move blobExistedInDBTotal but leave blobRecoveredFromELTotal there
There was a problem hiding this comment.
Yes, I think that's good too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
In the event we have no commitments in the block or that all blobs have been seen via gossip we exit our reconstruction routine early.
Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements