Fix Blobs By Range RPC Handler #14910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Networking
terencechain
approved these changes
Feb 11, 2025
prestonvanloon
approved these changes
Feb 11, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event Prysm needs to serve a blob range across the fork boundary between deneb and electra, this PR makes sure that we are able to always use the correct maximum value when serving the blob range. This PR also adds in a regression test which makes sure that we serve the correct number of blobs when serving blobs from electra blocks.
Which issues(s) does this PR fix?
Fixes a bug observed in #14875
Other notes for review
Acknowledgements