Fix Blob Reconstruction #14909
Merged
Fix Blob Reconstruction #14909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event the blob index mask is mutated by another routine, Prysm would end up building invalid blob sidecars. In order to prevent this from happening we now track the indexes of all the unseen commitments in a separate slice and use that as the canonical source of truth on which is the correct blob index. This allows us to not use the mutating bitmask and also only iterate through the unseen kzg commitments.
Which issues(s) does this PR fix?
Alternative to #14908
Other notes for review
Acknowledgements