Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconstruct blob sidecars to account HasIndex updates #14908

Closed
wants to merge 1 commit into from
Closed

Fix reconstruct blob sidecars to account HasIndex updates #14908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion beacon-chain/execution/engine_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,11 @@ func (s *Service) ReconstructBlobSidecars(ctx context.Context, block interfaces.

// Collect KZG hashes for non-existing blobs
var kzgHashes []common.Hash
kzgIndexes := make(map[int]bool)
for i, commitment := range kzgCommitments {
if !hasIndex(uint64(i)) {
kzgHashes = append(kzgHashes, primitives.ConvertKzgCommitmentToVersionedHash(commitment))
kzgIndexes[i] = true
}
}
if len(kzgHashes) == 0 {
Expand All @@ -569,7 +571,7 @@ func (s *Service) ReconstructBlobSidecars(ctx context.Context, block interfaces.
// Reconstruct verified blob sidecars
var verifiedBlobs []blocks.VerifiedROBlob
for i, blobIndex := 0, 0; i < len(kzgCommitments); i++ {
if hasIndex(uint64(i)) {
if !kzgIndexes[i] {
continue
}

Expand Down
3 changes: 3 additions & 0 deletions changelog/tt_fix_reconstruct_blob_sidecars.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Fix reconstruct blob sidecars for reference bug.
Loading