Fix startup log for config file values #14865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Feb 3, 2025
| @@ -65,6 +65,8 @@ func UnmarshalConfig(yamlFile []byte, conf *BeaconChainConfig) (*BeaconChainConf | |||
| } | |||
| // recompute SqrRootSlotsPerEpoch constant to handle non-standard values of SlotsPerEpoch | |||
| conf.SqrRootSlotsPerEpoch = primitives.Slot(math.IntegerSquareRoot(uint64(conf.SlotsPerEpoch))) | |||
| // Recompute the fork schedule | |||
| conf.InitializeForkSchedule() | |||
There was a problem hiding this comment.
isn't this already called when a new config set is initialized?
There was a problem hiding this comment.
Yes but the point is that this function explicitly may overwrite the fork epochs and versions and the maps are left unmodified in inconsistent state
terencechain
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we load a config file, we call eventually UnmarshalConfig which first copies the mainnet config by calling MainnetConfig().Copy().
MainnetConfig() calls InitializeForkSchedule which in turn calls to configForkSchedule(b) and configForkNames(b) so these maps are made from the default config and not from the config file. After that the unmarshaller finishes changing the config values, this will read the new fork versions and epochs from the config file, but not change the maps So the config file values printed at the end have bogus maps that do not corresponds to the config file.
What worries me is that even if this is corrected later, this function UnmarshalConfig is returning a bogus config in inconsistent state.