use refs _nativeTag if _reactInternalFiber is null #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i tested it on iOS version and works well to solve prscX#100
|
Thanks @iMokhles for the Effort and PR. I have merged the PR, will do a round of QA and post that will push the release. Thanks |
|
yes and you should keep in mind that i have a fork which solves the swift issue by importing the swift files directly from MaterialShowcase project without using cocoapods https://github.com/iMokhles/react-native-app-tour/tree/master/ios to solve #97 #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i tested it on iOS version and works well to solve #100