style: clarify answers.toml format
#11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duesee
commented
Aug 10, 2024
| @@ -34,6 +36,48 @@ pub struct Global { | |||
| pub root_ssh_keys: Vec<String>, | |||
| } | |||
|
|
|||
| #[derive(Clone, Deserialize, Serialize, Debug, PartialEq)] | |||
| #[serde(rename_all = "kebab-case", deny_unknown_fields)] | |||
| pub enum KeyboardLayout { | |||
There was a problem hiding this comment.
Moved here from bottom so that Global is fully defined after line 67.
| pub hdsize: Option<f64>, | ||
| } | ||
|
|
||
| // ----- End of `answers.toml` format definition ----- |
There was a problem hiding this comment.
After this line, there is no "external API" anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it more obvious what should actually be defined in
answers.toml(as I wasn't sure how up-to-date the Wiki is). I merely reordered the definitions and added some notes that, for example,Networkis actually constructed fromNetworkInAnswer.I hope you are interested in this kind of changes. If so, I can make another PR that more clearly separates the deserialization from
answers.toml. This would allow to tighten up the definitions (and maybe even derive a "Wizard" for theanswers.tomlfile -- if we want to.)