wow

foundry.toml

@@ -3,4 +3,4 @@ src = 'src'
 out = 'out'
 libs = ['lib']
 
-# See more config options https://github.com/foundry-rs/foundry/tree/master/config
+# See  more config options https://github.com/foundry-rs/foundry/tree/master/config

src/DNSShortPosition.sol

@@ -2,18 +2,36 @@
 pragma solidity ^0.8.15;
 
 
-contract DNSShortPosition{
+contract DNSShortPosition {
 
+    /*           ERRORS             */
+    error INVALID_USER(address entrant);
+
+    /// @notice Address of the controlling factory contract
     address immutable factory;
 
+    ///@notice Contains relevant data related to a position
+    struct CollateralData {
+        address token;
+        uint256 amount;
+        uint256 tokenId;
+        uint256 startPrice;
+    }
+
+
+
     constructor(address _factory){
         factory = _factory;
     }
 
+    /// @notice Instead of a modifier, we include this line at the start of every function
+    /// @notice This is to decrease contract bytecode size (find out more why)
     function onlyFactory() internal {
-        require(msg.sender==factory,"INVALID_USER");
+        if(msg.sender != factory){
+            revert INVALID_USER(msg.sender);
+        }
         _;
     }
 
-    struct Collateral
+
 }

src/DNSfactory.sol

@@ -19,7 +19,11 @@ import {AggregatorV3Interface} from "./AggregatorV3Interface.sol";
 
 interface DNSfactory is Ownable, DNSerc721 {
     /////////////////////////// STORAGE ///////////////////////////////////
-    address immutable DNSerc20_Address;
+
+    // DNS minting ERC20 address
+    address public immutable DNSerc20_Address;
+    // Dummy contract manipulating ShortPosition
+    address public immutable DNS_ShortPosition;
 
     // address => nonceCount
     mapping(address => uint256) addressNonce;
@@ -34,6 +38,7 @@ interface DNSfactory is Ownable, DNSerc721 {
     // erc20Address => Issupported
     mapping(address => bool) isERC20Supported;
 
+    /// @notice Chainlink Price Feed
     AggregatorV3Interface internal priceFeed;
 
     struct CollateralData {
@@ -190,8 +195,15 @@ interface DNSfactory is Ownable, DNSerc721 {
         quantity = quantity * (10 ** 10) * _quantity;
     }
 
-    function createShortPosition() internal returns(bool);
+    function createShortPosition() internal returns(bool){
+
+    }
+
+    function getShortPositionData() public returns(int256){
+
+    }
 
+
     function mintERC20DNS(uint256 theTokenId) external returns (bool) {
         require(!isMinted[theTokenId], "ALREADY_MINTED");
         CollateralData memory userPosition = tokenIDToPosition[theTokenId];