Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): match type with check results #7111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andoniaf
Copy link
Contributor

@andoniaf andoniaf commented Mar 4, 2025

Description

Some checks do not match their type in metadata with what the check reports as uid.

Examples can be found in this slack thread.

This PR solves the ones mentioned in the thread and some extra we could in the review.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andoniaf andoniaf requested review from a team as code owners March 4, 2025 14:05
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 4, 2025
@andoniaf andoniaf force-pushed the PRWLR-6391-review-resource-types-in-checks-metadata branch from 41b3247 to d8aa8c0 Compare March 4, 2025 14:20
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (f7a9187) to head (d8aa8c0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7111      +/-   ##
==========================================
+ Coverage   88.75%   88.78%   +0.03%     
==========================================
  Files        1207     1207              
  Lines       35041    35041              
==========================================
+ Hits        31099    31110      +11     
+ Misses       3942     3931      -11     
Flag Coverage Δ
prowler 88.78% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.78% <ø> (+0.03%) ⬆️
api ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant