feat(entra): add new check entra_admin_consent_workflow_enabled
#7110
+300
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7110 +/- ##
==========================================
+ Coverage 88.75% 88.76% +0.01%
==========================================
Files 1207 1208 +1
Lines 35041 35076 +35
==========================================
+ Hits 31099 31135 +36
+ Misses 3942 3941 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andoniaf
reviewed
Mar 4, 2025
| attributes = loop.run_until_complete( | ||
| gather( | ||
| self._get_authorization_policy(), | ||
| self._get_admin_consent_poolicy(), |
There was a problem hiding this comment.
Suggested change
| self._get_admin_consent_poolicy(), | |
| self._get_admin_consent_policy(), |
prob will need some search&replace, as it spread across the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a new check for Microsoft365 Entra. This check verifies that the admin consent workflow is enabled to manage user requests for application permissions. The recommendation for this check is to have that enabled and also to have notifications to the reviewers enabled.
We could add more recommendations like the number of days, notifications before the end of the consent period, number of reviewers,... but I think those parameters depend on the organization and should not be an evaluable part of the check.
Enabling this workflow ensures that administrators review and approve all permission requests, preventing unauthorized applications from accessing organizational resources and improving overall security governance.
Description
Added new check
entra_admin_consent_workflow_enabled, modified entra service and add unit tests.Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.