Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): ensure unique finding id in ECS checks #7059

Merged

Conversation

MrCloudSec
Copy link
Member

Context

Fix #7050

Description

Ensure Prowler creates unique Finding UIDs in ECS by using also the cluster name inside the service ID.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners February 27, 2025 11:04
@MrCloudSec MrCloudSec added the backport-to-v5.3 Backport PR to the v5.3 branch label Feb 27, 2025
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Feb 27, 2025
Copy link
Contributor

@andoniaf andoniaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@MrCloudSec MrCloudSec removed the backport-to-v5.3 Backport PR to the v5.3 branch label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (89237ab) to head (aae7cff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7059      +/-   ##
==========================================
+ Coverage   88.76%   88.79%   +0.03%     
==========================================
  Files        1201     1201              
  Lines       34920    34921       +1     
==========================================
+ Hits        30996    31008      +12     
+ Misses       3924     3913      -11     
Flag Coverage Δ
prowler 88.79% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.79% <100.00%> (+0.03%) ⬆️
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec merged commit e0a2628 into master Feb 27, 2025
13 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-6380-fix-ecs-service-no-assign-public-ip-check branch February 27, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finding UID for check ecs_service_no_assign_public_ip is not unique
2 participants