feat(m365): add sharepoint service with 4 checks #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and a check to test if things are working properly
…new checks following CIS recommendations
…ing to be used and add more description to status extended in admincenter checks
…tests still not working
…test connection, not working
…ptions, regions and mutelist
…nant is not allowed for microsoft365 and adjust admincenter service and checks to that change
…al to those that are either manual in the CIS or cant be done using msgraph SDK
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7057 +/- ##
==========================================
- Coverage 92.02% 88.78% -3.24%
==========================================
Files 79 1207 +1128
Lines 6986 35031 +28045
==========================================
+ Hits 6429 31103 +24674
- Misses 557 3928 +3371
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MrCloudSec
requested changes
Feb 27, 2025
MrCloudSec
changed the title
MrCloudSec
changed the title
andoniaf
reviewed
Feb 27, 2025
prowler/providers/microsoft365/services/sharepoint/sharepoint_service.py
Outdated
Show resolved
Hide resolved
andoniaf
reviewed
Feb 27, 2025
...point/sharepoint_modern_authentication_required/sharepoint_modern_authentication_required.py
Outdated
Show resolved
Hide resolved
MrCloudSec
approved these changes
Feb 27, 2025
cesararroba
pushed a commit
that referenced
this pull request
Mar 3, 2025
Co-authored-by: MarioRgzLpz <[email protected]> Co-authored-by: HugoPBrito <[email protected]> Co-authored-by: MrCloudSec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a new service for Microsoft365: SharePoint, which includes four new checks along with comprehensive tests for each and also for the service. All changes have been fully adapted to the latest refactor, ensuring consistency across the codebase.
The four new checks cover settings for SharePoint. They are:
sharepoint_external_sharing_managed: Validates that external sharing is managed in accordance with organizational policies (allowing or blocking access to certain domains).sharepoint_external_sharing_restricted: Ensures that external sharing is appropriately restricted to safeguard data.sharepoint_guest_sharing_restricted: Verifies that guest sharing is limited to prevent unauthorized access.sharepoint_modern_authentication_required: Confirms that modern authentication is enabled for enhanced security, this means that access for applications that don't use modern authentication is blocked.Description
Added new service with new checks and all the unit tests needed.
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.