Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stats): Use Finding instead of Check_Report #7053

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

jfagoagas
Copy link
Member

Description

Refactor extract_findings_statistics to use Finding instead of Check_Report_XXX.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners February 26, 2025 15:59
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (c452820) to head (72e3ab9).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7053      +/-   ##
==========================================
+ Coverage   88.72%   88.79%   +0.07%     
==========================================
  Files        1200     1207       +7     
  Lines       34832    35042     +210     
==========================================
+ Hits        30903    31117     +214     
+ Misses       3929     3925       -4     
Flag Coverage Δ
prowler 88.79% <80.55%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.79% <80.55%> (+0.07%) ⬆️
api ∅ <ø> (∅)

@AdriiiPRodri AdriiiPRodri force-pushed the use-finding-in-stats branch 2 times, most recently from e0b1e31 to ef2df6e Compare February 26, 2025 17:20
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug! 🔝

pedrooot
pedrooot previously approved these changes Feb 27, 2025
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug! 🔝

@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Feb 27, 2025
@jfagoagas jfagoagas removed the no-merge Please, DO NOT MERGE this PR. label Feb 28, 2025
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 👏🏼 👏🏼 👏🏼

@MrCloudSec MrCloudSec merged commit 9c33b3f into master Feb 28, 2025
11 of 12 checks passed
@MrCloudSec MrCloudSec deleted the use-finding-in-stats branch February 28, 2025 09:54
cesararroba pushed a commit that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants