Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iam): enhance iam_role_cross_service_confused_deputy_prevention recommendation #7023

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

HugoPBrito
Copy link
Member

Context

A user reported that the recommendation text for the check iam_role_cross_service_confused_deputy_prevention was not entirely accurate in certain cases:

Fix #7021

Description

This pull request aims to enhance the recommendation metadata field to ensure it is more precise and applicable to a broader range of scenarios.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito added backport-to-v3 Backport PR to the v3 branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.3 Backport PR to the v5.3 branch labels Feb 24, 2025
@HugoPBrito HugoPBrito requested review from a team as code owners February 24, 2025 17:38
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.67%. Comparing base (8a144a4) to head (dbc4dfd).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7023   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files        1200     1200           
  Lines       34647    34647           
=======================================
+ Hits        30722    30724    +2     
+ Misses       3925     3923    -2     
Flag Coverage Δ
prowler 88.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.67% <ø> (+<0.01%) ⬆️
api ∅ <ø> (∅)

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HugoPBrito !!

@MrCloudSec MrCloudSec changed the title feat(iam): enhance iam_role_cross_service_confused_deputy_prevention recommendation chore(iam): enhance iam_role_cross_service_confused_deputy_prevention recommendation Feb 26, 2025
@MrCloudSec MrCloudSec removed the backport-to-v3 Backport PR to the v3 branch label Feb 26, 2025
@MrCloudSec MrCloudSec merged commit 7f74b67 into master Feb 26, 2025
15 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-6297-enhance-recommendation-text branch February 26, 2025 06:37
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Feb 26, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.3 Backport PR to the v5.3 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS - IAM Role Cross Service Confused Deputy Prevention
3 participants