feat(microsoft365): add new check entra_admin_users_sign_in_frequency_enabled
#7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-existing-checks-not-to-add-resource-id-and-name' of https://github.com/prowler-cloud/prowler into PRWLR-6016-ensure-sign-in-frequency-is-enabled-and-browser-sessions-are-not-persistent-for-administrative-users
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7020 +/- ##
==========================================
- Coverage 88.70% 88.68% -0.02%
==========================================
Files 1200 1201 +1
Lines 34832 34915 +83
==========================================
+ Hits 30897 30966 +69
- Misses 3935 3949 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…bled-and-browser-sessions-are-not-persistent-for-administrative-users
MrCloudSec
reviewed
Feb 27, 2025
|
|
||
| report = CheckReportMicrosoft365( | ||
| metadata=self.metadata(), | ||
| resource=entra_client.conditional_access_policies, |
There was a problem hiding this comment.
Suggested change
| resource=entra_client.conditional_access_policies, | |
| resource={}, |
We cannot pass a dict as a resource.
MrCloudSec
reviewed
Feb 27, 2025
| ): | ||
| report = CheckReportMicrosoft365( | ||
| metadata=self.metadata(), | ||
| resource=entra_client.conditional_access_policies, |
There was a problem hiding this comment.
Suggested change
| resource=entra_client.conditional_access_policies, | |
| resource=policy, |
Same here, we cannot pass the entire dictionary as a resource.
MrCloudSec
reviewed
Feb 27, 2025
| "ResourceIdTemplate": "", | ||
| "Severity": "high", | ||
| "ResourceType": "", | ||
| "Description": "Ensure Sign-in frequency periodic reauthentication does not exceed 4 hours for E3 tenants, or 24 hours for E5 tenants using Privileged Identity Management.", |
There was a problem hiding this comment.
We are not checking the period of the sign-in frequency, only if it is enabled. Check if it is necessary to check the period, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In
Microsoft Entra ID, authentication sessions for administrative users must be carefully managed to reduce security risks. Persistent browser sessions and long reauthentication intervals can increase the risk of unauthorized access, especially if an administrator's session remains active on a compromised or shared device.Conditional Access policiesallow organizations to enforce stricter authentication requirements for high-privileged users, ensuring security best practices are followed.Description
This check ensures that Sign-in frequency is enabled and that browser sessions are not persistent for administrative users in
Microsoft Entra ID. Organizations should enforce periodic reauthentication to no more than4 hoursfor tenants.Additionally, the Persistent browser session setting should be configured to
Never persistentto prevent session cookies from being stored, reducing the risk of session hijacking. Implementing these policies helps minimize attack surfaces by requiring administrators to authenticate frequently and preventing session persistence across browsing sessions.Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.