-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(findings): Optimize findings endpoint #7019
feat(findings): Optimize findings endpoint #7019
Conversation
…bility-through-provider-is-deleted
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7019 +/- ##
==========================================
+ Coverage 88.66% 92.68% +4.02%
==========================================
Files 1200 76 -1124
Lines 34647 6698 -27949
==========================================
- Hits 30719 6208 -24511
+ Misses 3928 490 -3438
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI changes looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's impressive 👏 This is the way to go, thank you for taking care of it ❤️
Description
This PR includes a full refactor of the
GET /findings
endpoint logic, changing the way queries are built using the ORM andDRF-JSON:API
library. Theinclude
query parameter has also been changed to allow the following values:scan
scan.provider
resources
In addition, few composite and partial indexes have been added. Using our cloud DEV environment, here are the metrics comparison between the former implementation and this one:
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.