Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-manager): set health check and conn_max_age to 1 hour #6088

Closed

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Dec 9, 2024

Context

Django is revoking connections with the following exception: django.db.utils.InterfaceError: connection already closed

Description

  • Configure CONN_MAX_AGE for an hour instead of 0 which automatically closes the connection.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the backport-to-v5.0 Backport PR to the v5.0 branch label Dec 9, 2024
@jfagoagas jfagoagas requested a review from a team as a code owner December 9, 2024 15:44
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (d8fc830) to head (7f9b8e7).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6088      +/-   ##
==========================================
+ Coverage   89.93%   92.90%   +2.96%     
==========================================
  Files        1147       59    -1088     
  Lines       35611     5102   -30509     
==========================================
- Hits        32028     4740   -27288     
+ Misses       3583      362    -3221     
Flag Coverage Δ
api 92.90% <ø> (?)
prowler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 92.90% <ø> (∅)

@jfagoagas jfagoagas marked this pull request as draft December 9, 2024 16:18
@jfagoagas
Copy link
Member Author

Closing this since the issue was not introduced by Django.

@jfagoagas jfagoagas closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v5.0 Backport PR to the v5.0 branch component/api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant