Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup): modify list recovery points call #5996

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

danibarranqueroo
Copy link
Member

Context

@jfagoagas notified an issue when an object is empty in the call from Backup “Listing Recovery Points”:

image

Description

Added a condition to check if the recovery point list is empty or if the ARN does not exist. In such cases, no recovery point will be added to the list.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners December 3, 2024 10:56
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (50796be) to head (12bb022).
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5996      +/-   ##
==========================================
+ Coverage   89.95%   89.96%   +0.01%     
==========================================
  Files        1147     1147              
  Lines       35608    35611       +3     
==========================================
+ Hits        32031    32039       +8     
+ Misses       3577     3572       -5     
Components Coverage Δ
prowler 89.96% <100.00%> (+0.01%) ⬆️
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec added the backport-to-v5.0 Backport PR to the v5.0 branch label Dec 6, 2024
@MrCloudSec MrCloudSec merged commit 2ce8e1f into master Dec 6, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5666-fix-backup-listing-recovery-points branch December 6, 2024 12:35
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 6, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

MrCloudSec pushed a commit that referenced this pull request Dec 6, 2024
@jfagoagas jfagoagas added the backport-to-v4.6 Backport PR to the v4.6 branch label Dec 9, 2024
prowler-bot pushed a commit that referenced this pull request Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MrCloudSec MrCloudSec added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch and removed was-backported The PR was successfully backported to the target branch backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
5.0 The branch "5.0" does not exist

Manual backport

To create the backport manually run:

backport --pr 5996

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MrCloudSec MrCloudSec added backport-to-v5.0 Backport PR to the v5.0 branch and removed backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 9, 2024
prowler-bot pushed a commit that referenced this pull request Dec 9, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MrCloudSec MrCloudSec added backport-to-v5.0 Backport PR to the v5.0 branch and removed was-backported The PR was successfully backported to the target branch backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 9, 2024
prowler-bot pushed a commit that referenced this pull request Dec 9, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@MrCloudSec MrCloudSec added backport-to-v5.0 Backport PR to the v5.0 branch and removed was-backported The PR was successfully backported to the target branch backport-to-v5.0 Backport PR to the v5.0 branch labels Dec 9, 2024
prowler-bot pushed a commit that referenced this pull request Dec 9, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Dec 9, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v5.0

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v5.0 Backport PR to the v5.0 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants