Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcp): improve docstrings #5716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pedrooot
Copy link
Member

Description

This pull request enhances the GcpProvider class by adding comprehensive docstrings to its methods and attributes. These additions improve the documentation and usability of the class by detailing the purpose, arguments, return values, exceptions, and usage examples for each method.

Enhancements to documentation:

  • prowler/providers/gcp/gcp_provider.py: Added detailed class-level docstring to the GcpProvider class, describing its attributes and methods.

  • prowler/providers/gcp/gcp_provider.py: Added docstrings to the __init__, setup_session, test_connection, get_projects, update_projects_with_organizations, is_project_matching, validate_static_arguments, and validate_project_id methods to include descriptions of arguments, return values, exceptions, and usage examples. [1] [2] [3] [4] [5] [6] [7] [8]

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners November 11, 2024 13:03
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (344d541) to head (fcba8af).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5716      +/-   ##
==========================================
- Coverage   89.94%   89.92%   -0.02%     
==========================================
  Files        1124     1128       +4     
  Lines       34815    35182     +367     
==========================================
+ Hits        31313    31638     +325     
- Misses       3502     3544      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedrooot pedrooot changed the title feat(gcp): improve docstings feat(gcp): improve docstrings Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant