Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secretsmanager): add new check secretsmanager_secret_rotated_periodically #5450

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Oct 17, 2024

Context

Add new configurable check to ensure if secrets have rotated in certain amount of time.

Description

  • Add last_rotated to Secret model
  • Test new Secret attribute
  • Add configurable attribute max_days_secret_unrotated
  • Add check logic
  • Add unit testing for the check

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 17, 2024 13:29
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider labels Oct 17, 2024
@puchy22 puchy22 changed the base branch from master to PRWLR-4481-remove-unused-secrets-manager-secrets October 17, 2024 13:29
Base automatically changed from PRWLR-4481-remove-unused-secrets-manager-secrets to master October 17, 2024 14:24
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (a17cf1b) to head (b808284).
Report is 100 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5450      +/-   ##
==========================================
+ Coverage   89.36%   89.81%   +0.44%     
==========================================
  Files        1053     1112      +59     
  Lines       32649    34492    +1843     
==========================================
+ Hits        29178    30980    +1802     
- Misses       3471     3512      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

You can check the documentation for this PR here -> Prowler Documentation

@MrCloudSec MrCloudSec merged commit 1b50fdb into master Nov 4, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4484-rotate-secrets-manager-secrets-within-a-specified-time-frame branch November 4, 2024 21:08
MrCloudSec added a commit that referenced this pull request Nov 12, 2024
MrCloudSec added a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants