Skip to content

Commit

Permalink
fix: flake 8
Browse files Browse the repository at this point in the history
  • Loading branch information
MrCloudSec committed Feb 26, 2025
1 parent 5c6c7d3 commit e8ccd66
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 12 deletions.
22 changes: 13 additions & 9 deletions prowler/providers/nhn/services/network/network_service.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
from pydantic import BaseModel

from prowler.lib.logger import logger
from prowler.providers.nhn.nhn_provider import NhnProvider


class Subnet(BaseModel):
name: str
external_router: bool
enable_dhcp: bool



class Network(BaseModel):
id: str
name: str
empty_routingtables: bool
subnets: list[Subnet]


class NHNNetworkService:
def __init__(self, provider: NhnProvider):
self.session = provider.session
Expand All @@ -31,7 +35,7 @@ def _list_vpcs(self) -> list:
except Exception as e:
logger.error(f"Error listing vpcs: {e}")
return []

def _get_vpc_detail(self, vpc_id: str) -> dict:
url = f"{self.endpoint}/v2.0/vpcs/{vpc_id}"
try:
Expand All @@ -41,17 +45,17 @@ def _get_vpc_detail(self, vpc_id: str) -> dict:
except Exception as e:
logger.error(f"Error getting vpc detail {vpc_id}: {e}")
return {}

def _check_has_empty_routingtables(self, vpc_info: dict) -> bool:
routingtables = vpc_info.get("routingtables", [])
return not routingtables

def _check_subnet_has_external_router(self, subnet: dict) -> bool:
return subnet.get("router:external", True)

def _check_subnet_enable_dhcp(self, subnet: dict) -> bool:
return subnet.get("enable_dhcp", True)

def _get_networks(self):
vpc_list = self._list_vpcs()
for vpc in vpc_list:
Expand All @@ -65,11 +69,11 @@ def _get_networks(self):
id=vpc_id,
name=vpc_name,
empty_routingtables=vpc_empty_routingtables,
subnets=[]
subnets=[],
)
self._get_subnets(vpc_info, network)
self.networks.append(network)

def _get_subnets(self, vpc_info: dict, network: Network):
subnet_list = vpc_info.get("subnets", [])
# ret_subnet_list = []
Expand All @@ -80,6 +84,6 @@ def _get_subnets(self, vpc_info: dict, network: Network):
subnet_instance = Subnet(
name=subnet_name,
external_router=subnet_external_router,
enable_dhcp=subnet_enable_dhcp
enable_dhcp=subnet_enable_dhcp,
)
network.subnets.append(subnet_instance)
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
from prowler.lib.check.models import Check, Check_Report_NHN
from prowler.providers.nhn.services.network.network_client import network_client


class network_vpc_has_empty_routingtables(Check):
def execute(self):
findings = []
for network in network_client.networks:
report = Check_Report_NHN(metadata=self.metadata(), resource=network)
report.status = "PASS"
report.status_extended = f"VPC {network.name} does not have a empty routingtables."
report.status_extended = (
f"VPC {network.name} does not have a empty routingtables."
)
if network.empty_routingtables:
report.status = "FAIL"
report.status_extended = f"VPC {network.name} has a empty routingtables."
report.status_extended = (
f"VPC {network.name} has a empty routingtables."
)
findings.append(report)

return findings
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from prowler.lib.check.models import Check, Check_Report_NHN
from prowler.providers.nhn.services.network.network_client import network_client


class network_vpc_subnet_enable_dhcp(Check):
def execute(self):
findings = []
Expand All @@ -11,7 +12,9 @@ def execute(self):
report.status_extended = f"VPC {network.name} Subnet {subnet.name} does not have DHCP enabled."
if subnet.enable_dhcp:
report.status = "FAIL"
report.status_extended = f"VPC {network.name} Subnet {subnet.name} has DHCP enabled."
report.status_extended = (
f"VPC {network.name} Subnet {subnet.name} has DHCP enabled."
)
findings.append(report)

return findings
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from prowler.lib.check.models import Check, Check_Report_NHN
from prowler.providers.nhn.services.network.network_client import network_client


class network_vpc_subnet_has_external_router(Check):
def execute(self):
findings = []
Expand Down

0 comments on commit e8ccd66

Please sign in to comment.