chore(sharepoint): refactor service test

prowler-cloud · Feb 27, 2025 · 18895d5 · 18895d5
1 parent 44b796e
commit 18895d5
Showing 1 changed file with 9 additions and 35 deletions.
diff --git a/tests/providers/microsoft365/services/sharepoint/sharepoint_service_test.py b/tests/providers/microsoft365/services/sharepoint/sharepoint_service_test.py
@@ -2,7 +2,6 @@
 
 from prowler.providers.microsoft365.models import Microsoft365IdentityInfo
 from prowler.providers.microsoft365.services.sharepoint.sharepoint_service import (
-    OneDriveSharedContent,
     SharePoint,
     SharePointSettings,
 )
@@ -13,35 +12,20 @@
 
 
 async def mock_sharepoint_get_settings(_):
-    return {
-        DOMAIN: SharePointSettings(
-            id=DOMAIN,
-            sharingCapability="ExternalUserAndGuestSharing",
-            sharingAllowedDomainList=["allowed-domain.com"],
-            sharingBlockedDomainList=["blocked-domain.com"],
-            sharingDomainRestrictionMode="allowList",
-            resharingEnabled=False,
-            modernAuthentication=True,
-        )
-    }
-
-
-async def mock_sharepoint_get_one_drive_shared_content(_):
-    return {
-        DOMAIN: OneDriveSharedContent(
-            totalSharedContent=42,
-        )
-    }
+    return SharePointSettings(
+        sharingCapability="ExternalUserAndGuestSharing",
+        sharingAllowedDomainList=["allowed-domain.com"],
+        sharingBlockedDomainList=["blocked-domain.com"],
+        sharingDomainRestrictionMode="allowList",
+        resharingEnabled=False,
+        modernAuthentication=True,
+    )
 
 
 @patch(
     "prowler.providers.microsoft365.services.sharepoint.sharepoint_service.SharePoint._get_settings",
     new=mock_sharepoint_get_settings,
 )
-@patch(
-    "prowler.providers.microsoft365.services.sharepoint.sharepoint_service.SharePoint._get_one_drive_shared_content",
-    new=mock_sharepoint_get_one_drive_shared_content,
-)
 class Test_SharePoint_Service:
     def test_get_client(self):
         sharepoint_client = SharePoint(
@@ -53,20 +37,10 @@ def test_get_client(self):
 
     def test_get_settings(self):
         sharepoint_client = SharePoint(set_mocked_microsoft365_provider())
-        assert DOMAIN in sharepoint_client.settings
-        settings = sharepoint_client.settings[DOMAIN]
-
-        assert settings.id == DOMAIN
+        settings = sharepoint_client.settings
         assert settings.sharingCapability == "ExternalUserAndGuestSharing"
         assert settings.sharingAllowedDomainList == ["allowed-domain.com"]
         assert settings.sharingBlockedDomainList == ["blocked-domain.com"]
         assert settings.sharingDomainRestrictionMode == "allowList"
         assert settings.resharingEnabled is False
         assert settings.modernAuthentication is True
-
-    def test_get_one_drive_shared_content(self):
-        sharepoint_client = SharePoint(set_mocked_microsoft365_provider())
-        assert DOMAIN in sharepoint_client.one_drive_shared_content
-        shared_content = sharepoint_client.one_drive_shared_content[DOMAIN]
-
-        assert shared_content.totalSharedContent == 42