Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[#108] Update watchdog_pet()" #209

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

blakejameson
Copy link
Contributor

Reverts #189

Currently, when running the code on the main branch, it eventually gets to a point where the only output is "petting watchdog". The other code in the main loop isn't showing that it's running whenever this occurs

Screenshot 2025-03-24 at 12 17 14 PM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Mikefly123
Copy link
Member

Hey @blakejameson I'm going to spend a bit of time today trying to see if we can fix the bug you described in #205. I'm not sure yet, but my best guess is that when we do go to safe_sleep it somehow is nuking the asyncio instance in main.

        while duration >= 15 and iterations < 12:
            time_alarm: circuitpython_typing.Alarm = alarm.time.TimeAlarm(
                monotonic_time=time.monotonic() + 15
            )

            alarm.light_sleep_until_alarms(time_alarm)
            duration -= 15
            iterations += 1

            self.cubesat.watchdog_pet()

Will report back after a bit of testing.

Copy link
Member

@Mikefly123 Mikefly123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in #205. I was unable to reproduce the bug that leads to this PR. Might just be a config issue or maybe an incompatibility between different versions of CircuitPython?

@Mikefly123
Copy link
Member

Okay actually scratch what I previously said, I am now seeing the bug. Will continue working the problem!

Copy link
Member

@nateinaction nateinaction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepping for repo conversion. Will not be possible to revert PR after conversion. I intend to put up a new PR with the async changes.

@nateinaction nateinaction merged commit c2997ea into main Mar 26, 2025
3 of 4 checks passed
@nateinaction nateinaction deleted the revert-189-feat/watchdog_async branch March 26, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants