Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.20.0-rc2 #2182

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Mark v1.20.0-rc2 #2182

merged 3 commits into from
Oct 16, 2024

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Oct 15, 2024

Description

This PR marks v1.20.0-rc2 in the changelog and release changelog because v1.20.0-rc1 had the release changelog named the wrong thing, so it didn't actually create the release.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@SpicyLemon SpicyLemon requested a review from a team as a code owner October 15, 2024 23:01
@SpicyLemon SpicyLemon enabled auto-merge (squash) October 15, 2024 23:02
@SpicyLemon SpicyLemon disabled auto-merge October 16, 2024 01:51
@SpicyLemon
Copy link
Contributor Author

SpicyLemon commented Oct 16, 2024

Gonna need #2184 in this too, so putting it back into draft. It's in, so this is ready again.

@SpicyLemon SpicyLemon marked this pull request as draft October 16, 2024 02:12
@SpicyLemon SpicyLemon marked this pull request as ready for review October 16, 2024 15:36
@SpicyLemon SpicyLemon merged commit fa0263a into release/v1.20.x Oct 16, 2024
21 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/prep-v1.20.0-rc2 branch October 16, 2024 15:42
@SpicyLemon SpicyLemon mentioned this pull request Oct 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants