Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Docs 1708 setup client documentation #29

Merged
merged 13 commits into from
Aug 8, 2024

Conversation

parth-kulkarni1
Copy link
Collaborator

@parth-kulkarni1 parth-kulkarni1 commented Jul 26, 2024

Jira-1708 (Major/Minor/Bug Fix): Minor

JIRA Ticket 1708

Checklist

  • If tests are required for this change, are they implemented?
  • Are user documentation changes required, if so, is there a task to track it and/or is it completed?
  • If developer/system documentation updates are required, is there a task to track it and/or is it completed?
  • At least one developer has reviewed this change (unless PR is being used to mark a commit point without need for review)?

Description

Had to re-create PR to update cd job to re-install poetry, build docs, and upload. Before, CI job was building docs, and CD job was just attempting to push using poetry however they are on different runners/environments so this will not have worked!

Notes for reviewer

... (Optional) Notes here...

@Rosspet
Copy link
Collaborator

Rosspet commented Aug 7, 2024

Is there a place where I can see the docs being built?

@Rosspet Rosspet self-requested a review August 8, 2024 01:41
Copy link
Collaborator

@Rosspet Rosspet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good nice job

@parth-kulkarni1 parth-kulkarni1 merged commit 673dc6a into main Aug 8, 2024
2 checks passed
@parth-kulkarni1 parth-kulkarni1 deleted the docs-1708-setup-client-documentation branch August 8, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants