Helm chart: Add service labels and document service annotations #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorenzboguhn hey, as this repo is not maintained (provectus/kafka-ui#4255), could you raise one at https://github.com/kafbat/helm-charts/ instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This MR is based on the also created issue: #35 Helm chart: Add service labels and document service annotations
It adds the possibility to define labels for the service via the helm values.
Additionally, it documents the possibility to define annotations on the service.
Related issues:
#25 Add custom labels for the Ingress
#28 Add custom labels to deployment
Best Regards
Lorenz