Skip to content

Move clippy into CI #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Move clippy into CI #231

merged 3 commits into from
Apr 5, 2023

Conversation

Pat-Lafon
Copy link
Contributor

With #228 and previously #217, a couple of pr's have been accepted to address clippy suggestions. Given this, it seems reasonable to move clippy into the github actions workflow.

This pr:

  • Adds an additional, parallel job to the workflow to run clippy across the whole workspace.
  • Picks some low hanging ci performance fruit by using CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse and not statically building z3 twice(As I later found mentioned in Stop ignoring errors in CI. #207 (comment)).
  • Fixes the last of clippy's suggestions in various build/test files.

Depending on the status of #207, it would be faster to run clippy without static-link-z3. Sometimes people also move cargo fmt into the ci.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase the commit for running clippy in parallel into the commit where you added the config to run clippy in CI?

@Pat-Lafon
Copy link
Contributor Author

I have cleaned up the commit history.

@Pat-Lafon Pat-Lafon requested a review from waywardmonkeys April 5, 2023 13:54
@waywardmonkeys waywardmonkeys merged commit 4360410 into prove-rs:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants