Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector v3 docs): adds documentation of new v3 features #23

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

gskapka
Copy link

@gskapka gskapka commented May 23, 2019

...PRd here for intial read-over/review by @D-Nice.

@gskapka gskapka requested a review from D-Nice May 23, 2019 18:15
@gskapka gskapka self-assigned this May 23, 2019
Copy link

@D-Nice D-Nice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments need addressing

Copy link

@D-Nice D-Nice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait before merging until connector is live

@D-Nice
Copy link

D-Nice commented Jun 10, 2019

still LGTM

@riccardopersiani
Copy link

@gskapka, if not finished, I can review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants