Support vendors in blade directive and Request #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this feature in #28.
I added support for multi vendors via configuration in Request:
Usage:
Also, I added support for multi vendors in blade directive:
Both changes are covered in unit tests. What have left is to add support for
verifySignature
inWebhookController
, but only this method can support overloading public_key from config, not the controller because I think we can't support multi-vendors in that case. Users need to create own controllers because they know where from they will readpublic_key
.We can discuss Do we want to change
WebhookController
or not.