Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lang select #81

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Lang select #81

merged 1 commit into from
Oct 10, 2024

Conversation

bdon
Copy link
Member

@bdon bdon commented Oct 10, 2024

@wipfli we can expose the language list in the JS library so I don't need to copy it here

wipfli
wipfli approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@bdon bdon merged commit e7331e5 into main Oct 10, 2024
1 check passed
@wipfli
Copy link
Contributor

wipfli commented Oct 10, 2024

Maybe sort alphabetically by language that the user sees in the dropdown

@wipfli
Copy link
Contributor

wipfli commented Oct 10, 2024

https://github.com/protomaps/basemaps/blob/8ec42aa5009bf6589a6bd9ae571f2d02aa28921d/app/src/MapViewComponent.tsx#L398C3-L398C80 like here

@bdon bdon deleted the lang-select branch October 10, 2024 16:55
@bdon
Copy link
Member Author

bdon commented Oct 11, 2024

Fixed in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wipfli wipfli wipfli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdon @wipfli