Boundaries admin level 3 5 #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nvkelso
reviewed
Jan 5, 2024
| @@ -199,6 +199,13 @@ public void processFeature(SourceFeature sf, FeatureCollector features) { | |||
| // Natural Earth is used for low zooms (for compilation and tile size reasons) | |||
| themeMinZoom = 6; | |||
| } | |||
| // used in Colombia, Brazil, Kenya (historical) | |||
There was a problem hiding this comment.
Beware: In Brazil there are several "statistical" groupings of actual administrative regions. Some of these are in conventional usage, some are not. I'm also wary of adding historical boundary lines. However, since the map looks broken without this change we should make it... but worth some more research...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #189 for screenshots