don't require man_made=bridge outlines have area=yes [#180] #182
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
Looks good to me |
| @@ -21,14 +21,14 @@ public void processFeature(SourceFeature sf, FeatureCollector features) { | |||
| sf.hasTag("landuse", "recreation_ground", "industrial", "brownfield", "railway", "cemetery", "commercial", | |||
| "grass", "orchard", "farmland", "farmyard", "residential", "military") || | |||
| sf.hasTag("leisure", "park", "garden", "golf_course", "dog_park", "playground", "pitch", "nature_reserve") || | |||
| sf.hasTag("man_made", "pier") || | |||
| sf.hasTag("man_made", "pier") || sf.hasTag("man_made", "bridge") || | |||
There was a problem hiding this comment.
Nit, since these are both the same tag key, rewrite asa list of values, like:
sf.hasTag("man_made", "pier", "bridge") ||
There was a problem hiding this comment.
Agree that in the case of bridge it's assumed to be a polygon per the wiki and in practice.
There was a problem hiding this comment.
Does this need a style change, too? Something like id: "landuse_pedestrian", either duplicating that style layer or adding bridge to it's the filter?
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you include a before/after screenshot showing the data change in the style?
(I think that style layer filter needs a logic change...)
There was a problem hiding this comment.
Will provide visual test link when the 3.0.1 build completes tomorrow... think the style with pmap:kind=pedestrian is good enough
* make landuse filters more concise
|
|
@nvkelso visual test output comparing tileset builds: 
|
|
Great bug fix! |
See #180
Refer to https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dbridge :
@wipfli @nvkelso