Resolve different signedness warning #21944
Conversation
The size() by default returns an unsigned integer datatype. In other places in this code a C cast style is used. Follow the same resolution, and cast the unsigned integer type to signed integer.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Proposal for solving #21938 |
| @@ -177,7 +177,7 @@ void GenerateLarge( | |||
| }}, | |||
| {"aliases", | |||
| [&] { | |||
| for (int i = 0; i < aliases.size(); i++) { | |||
| for (int i = 0; i < (int)aliases.size(); i++) { | |||
There was a problem hiding this comment.
how about size_t i = 0; without the cast?
There was a problem hiding this comment.
I totally agree with the proposal of size_t. However the rest of the code in this file uses a C cast and I just wanted to be consistent.
There was a problem hiding this comment.
Using the suggested solution size_t i = 0; without the cast.
The size() by default returns size_t datatype. Update the data type for the loop iterator to resolve compiler warning for signedness mismatch.
mkruskal-google
added
cleanup
protoc
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
The size() by default returns an unsigned integer datatype. In other places in this code a C cast style is used. Follow the same resolution, and cast the unsigned integer type to signed integer.