Sort explanation services (updated) #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying changes in a ExplanationPreferencesGeneralPanel dialog, save the changes to an instance-level ExplanationPreferences object (that has itself been loaded upon initialisation of the dialog), rather than to a new object created on the fly. This ensure that any previously set "last explanation service" setting is preserved.
When initialising the ExplanationPreferencesGeneralPanel dialog, make sure the "up" and "down" buttons are disabled if no row is selected in the list of available explanation services (which is normally the case when the dialog is created).
Add a label next to the "move up" / "move down" buttons in the ExplanationPreferencesGeneralPanel dialog, to hopefully make it clearer that the order of the listed explanation services matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon @stefborg’s #1059 to add the fixes recommended by @ykazakov :
ExplanationPreferencesobject when applying the changes in the preference dialog;(I hope you don’t mind, @stefborg. I’m keen to release 5.6.4 before the end of the week.)