Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove npm release check for testing provider mock #1450

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/provider_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,26 +157,8 @@ jobs:
echo "Building the provider-mock package..."
npm run -w @prosopo/provider-mock build

- name: Get the latest released version of npm packages
id: npm_released
run: |
set -euxo pipefail # stop on errors, print commands, fail on pipe fails
RELEASED_VERSION="$(npm view @prosopo/util | grep latest | cut -f2 -d ' ')"
VERSION="$(jq -r .engines.npm < package.json)"
if [[ "$RELEASED_VERSION" != "$VERSION" ]]; then
# shellcheck disable=SC2086
echo "npm_released=false" >> $GITHUB_ENV
elif [[ "$RELEASED_VERSION" == "$VERSION" ]]; then
# shellcheck disable=SC2086
echo "npm_released=true" >> $GITHUB_ENV
else
echo "cannot determine if npm_released"
exit 1
fi

# create the provider mock image for AMD64
- name: Build the Provider Mock Container
if: steps.npm_released.outputs.npm_released == 'true'
id: build_docker_provider_mock_amd64
continue-on-error: false
uses: docker/build-push-action@v5
Expand All @@ -190,12 +172,10 @@ jobs:

# load the provider-mock AMD64 image
- name: Load the Provider Container
if: steps.npm_released.outputs.npm_released == 'true'
run: docker load -i provider-mock-amd64.tar

# Check that the version command works when running the bundle in the provider image
- name: Check provider mock container runs
if: steps.npm_released.outputs.npm_released == 'true'
run: |
CONTAINER="$(docker run -d -p 9229:9229 prosopo/provider-mock:dev)"
sleep 10s
Expand Down
Loading