-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(passport): Inclusion of magic links for email OTPs #2749
feat(passport): Inclusion of magic links for email OTPs #2749
Conversation
} | ||
const isBot = | ||
cfReq.cf && | ||
cfReq.cf.botManagement.score <= 30 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this need to be adjusted, based on our convo on confidence of request coming from human?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - quite sure it's automated
99 - quite sure it's human
Wonder what it should be. I tried it on dev with gmail, outlook, iOS web and it seemed to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should be safe(r) if we do auto-verification only in the last 10 percent points of confidence of humanness.
ce907e7
to
7cb6cd3
Compare
verification flow
button styles
7cb6cd3
to
4dc248b
Compare
Description
Related Issues
Testing
Checklist