Skip to content

TypoFixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

TypoFixes #2

wants to merge 9 commits into from

Conversation

bcooney93
Copy link

here is the first batch of typo fixes.

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proofkit ✅ Ready (Inspect) Visit Preview Nov 18, 2024 10:15pm

@@ -69,25 +69,25 @@ From [The Copenhagen Book](https://thecopenhagenbook.com/sessions):

The session layout also includes related fields for the user, so user info can be fetched in a single request via the FileMaker Data API. **Unless you change the types in the code**, you should expect all data from this layout to be available to the currently logged in user in the browser.

By default, the layout for the session table should be named `proofkit_auth_sessions` but this can be customized in the fmschema.config.mjs file.
By default, the layout for the session table is named `proofkit_auth_sessions` but this can be customized in the fmschema.config.mjs file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-think this wording? I want to make it clear that the layouts can be renamed if you edit the fmscheama.config file, but that these are default expected names if you don't use the add-on for some reason and just make the layouts manually

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using "should be" seems to imply the default naming might fail. That's why I suggested "is"

Copy link
Collaborator

@eluce2 eluce2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few wording tweaks I think change the meaning too much. Review comments


## The `src/app` directory

This is the Next.js app router. Learn more at the [Next.js docs](https://nextjs.org/docs/app/building-your-application/routing), and make sure you're looking at the guides for "using the app router".
This is the Next.js app router. Learn more at the [Next.js docs](https://nextjs.org/docs/app/building-your-application/routing), specifically the section that discusses "using the app router".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the nextjs docs, there is really 2 "modes" to view them in: "using the app router" or "using the pages router" so I dont' think if "section" is the right term here

If you change the "mode" of the docs, the entire sidebar changes...

CleanShot 2024-11-18 at 16.48.01@2x.png

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about, "...specifically "using the app router"."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if in quotes it should say "Using App Router", but sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants