-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pronamic/pronamic-changelog-md-to-wordpress-plugin-readme-txt
#390
Use pronamic/pronamic-changelog-md-to-wordpress-plugin-readme-txt
#390
Conversation
I have tested this on https://plugins.trac.wordpress.org/browser/salesfeed/tags/1.3.3/readme.txt, but it is not reflected on https://nl.wordpress.org/plugins/salesfeed/#developers. It seems there are some issues on WordPress.org.
https://wordpress.slack.com/archives/C1LBM36LC/p1727782407080529
https://wordpress.slack.com/archives/C02RQBWTW/p1727772874487819 If this is working on ok and approved by @rvdsteege we can tag 1.0.0 of https://github.com/pronamic/pronamic-changelog-md-to-wordpress-plugin-readme-txt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
Do I understand correctly though, that the start and end markers in the CHANGELOG.md
file need to be updated manually for each release? Would it be possible / nice if that is optional and that, by default (without any markers in the Markdown), it just takes the same number of releases that are already between the markers in the readme.txt
(number of lines starting with ##
) and replace these with the releases from the Markdown?
Yes, that's right, but as far as I'm concerned the marker doesn't need to be moved up for every release.
Yes, that could be done, but it would make the https://github.com/pronamic/pronamic-changelog-md-to-wordpress-plugin-readme-txt library a bit more complex. That's why I mentioned this in the
It may not be a big deal that changelog entries in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll experience if this works in practice 🙂 If pronamic/pronamic-changelog-md-to-wordpress-plugin-readme-txt
needs any improvements later, I'll open an issue there.
No description provided.