Merge pull request #195 from pronamic/194-active-subscription-put-on-…

…hold-when-first-payment-expires

Fix operator for checking subscription status on first payment attempt.

src/Subscriptions/SubscriptionsModule.php

@@ -165,7 +165,7 @@ public function payment_status_update( $payment ) {
 				case PaymentStatus::CANCELLED:
 				case PaymentStatus::EXPIRED:
 					// Set subscription status to 'On Hold' only if the subscription is not already active when processing the first payment.
-					if ( $subscription->is_first_payment( $payment ) && SubscriptionStatus::ACTIVE === $subscription->get_status() ) {
+					if ( ! ( $subscription->is_first_payment( $payment ) && SubscriptionStatus::ACTIVE === $subscription->get_status() ) ) {
 						$status_update = SubscriptionStatus::ON_HOLD;
 					}