[WIP] Typescript Migration #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devorein
requested changes
Mar 25, 2023
| @@ -2,12 +2,14 @@ | |||
| "name": "promptifyjs", | |||
| "version": "0.0.1", | |||
| "description": "Prompt Engineering, Solve NLP Problems with LLM's & Easily generate different NLP Task prompts for popular generative models like GPT, PaLM, and more with Promptify", | |||
| "main": "index.js", | |||
There was a problem hiding this comment.
There is no dist/index.js file in the build output. We should create an index.ts file inside src first.
| @@ -3,6 +3,11 @@ export const binaryClassification = ({ | |||
| description = "", | |||
| labels = "", | |||
| examples = [], | |||
| }: { | |||
| text_input?: string; | |||
| description?: string; | |||
There was a problem hiding this comment.
description is not optional. There are a few keys that are required at all times.
There was a problem hiding this comment.
We are duplicating the same prompt section. Please conditionally generate the prompt based on whether domain is available or not
|
There are a few places where we are using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Migrating to Typescript (#7).
Features:
Lackings: