Fix panic when parsing invalid lines

[matthiasr]

The line

|h|#consumer:Kafka::SharedConfigurationConsumer,topic:shared_configuration_update,partition:1,consumer_group:tc_rc_us

caused a panic because the line parsing first splits by : and then failed to
find a | to split on.

Check that we get at least two "line parts" (i.e. splits around |) when we
expect them, and if not, gracefully reject the line instead of crashing.

Fixes #572.

Signed-off-by: Matthias Rampke [email protected]

[matthiasr]

@GrgDev can you check my thinking here?

@m-barthelemy @twskipper if you have a chance, could you give this branch a spin to make sure it fixes the panic in your real world use cases, not just in unit tests?

[m-barthelemy]

@GrgDev can you check my thinking here?

@m-barthelemy @twskipper if you have a chance, could you give this branch a spin to make sure it fixes the panic in your real world use cases, not just in unit tests?

I'd be happy to, but I don't know how to build an image from this project, had a quick look at the Dockerfile but it expects some already existing binary. Alternatively if there's an easy way for you to make a beta release image available on the Docker Hub, then it will be easy for me to test it on one of our non-production clusters.

[matthiasr]

Here you go: prom/statsd-exporter:v0.27.2-pr579

[m-barthelemy]

Here you go: prom/statsd-exporter:v0.27.2-pr579

Thanks a ton!
Complete success so far:

• no more crashes
• can see ts=2024-09-17T03:04:11.508Z caller=line.go:234 level=debug msg="bad line: not enough '|'-delimited parts after first ':'" ... warnings being logged instead

[m-barthelemy]

Thanks again for the fix! Will there be a new release and new Docker images soon?

[matthiasr]

Yes! I was on vacation, sorry :)

[matthiasr]

v0.27.2 is out!