Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking]: Reject lines with disabled tagging styles #580

Open
matthiasr opened this issue Sep 15, 2024 · 0 comments
Open

[breaking]: Reject lines with disabled tagging styles #580

matthiasr opened this issue Sep 15, 2024 · 0 comments
Labels
breaking Breaking Change

Comments

@matthiasr
Copy link
Contributor

Prerequisite to #576. Even when a specific tagging/labeling style is disabled, we still accept the line, but ignore these tags. Now that DogStatsD is extending the protocol not just for tagging, but also for other features such as packing multiple observations into one line, it becomes very difficult to reason about what should happen with a particular line given a particular configuration, and it becomes nearly impossible to optimize the line parser for the most common use case of having only one flavor in play. There is so much leeway in each of the formats that it is not guaranteed we can even uniquely make sense of a given mixed line.

The line parser should

  • determine the flavor of each line
  • accept lines using one (or none) of the enabled protocol flavors
  • reject lines using flavors that have been disabled
  • reject lines using more than one flavor

This will also allow us to refactor the line test suite and have a single, consolidated corpus of test cases, where each test case specifies the flavor it represents, rather than duplicating lines across the different tests with different expected outputs.

cc @pedro-stanaka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Change
Projects
None yet
Development

No branches or pull requests

1 participant