proc_stat_test.go: architecture dependent MinInt and MaxInt constants #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid `math.MinInt64` and `math.MaxInt64` overflowing `int` type when running `TestProcStatLimits` on 32bit architectures: ``` ./proc_stat_test.go:97:49: cannot use math.MinInt64 (untyped int constant -9223372036854775808) as int value in struct literal (overflows) ./proc_stat_test.go:98:51: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows) ``` Fixes: prometheus#432 Signed-off-by: Tim Rots <[email protected]>
|
Hrmm how is this working with the fixture having the same values on all archs? |
|
I clearly didn't understand the issue. Sorry for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid
math.MinInt64andmath.MaxInt64overflowinginttypewhen running
TestProcStatLimitson 32bit architectures:Fixes: #432
Signed-off-by: Tim Rots [email protected]