-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RDMA collector #3176
base: master
Are you sure you want to change the base?
Add RDMA collector #3176
Conversation
This looks super useful for GPU clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look at the new data reading library and I'm not very happy with it.
The main issue is this isn't setup to respect the sysPath
and rootfsPath
variables in paths.go
. This means this collector will fail when running in a container when the host sysfs is remapped to a different path.
@SuperQ Thank you for the review! I've updated the code as per your comments. I'll also open an issue in rdmamap to see if the |
Still doesn't seem to support using different dirs for the files its reading |
Please see lines 122-139 at |
Signed-off-by: Xiaodong Ye <[email protected]>
Signed-off-by: Xiaodong Ye <[email protected]>
Signed-off-by: Xiaodong Ye <[email protected]>
Signed-off-by: Xiaodong Ye <[email protected]>
Signed-off-by: Xiaodong Ye <[email protected]>
Ah I missed this, ok this looks better. Not a fan of that libs using global vars for this but good enough IMO. But the names need change, see above |
No problem! I’ll update the code accordingly and request your review once it's ready. Thanks! |
Signed-off-by: Xiaodong Ye <[email protected]>
This PR collects RDMA stats using rdmamap.
Testing Done
docker run --pull=always --cap-add=SYS_TIME --net=host -it node-exporter-linux-amd64:master --collector.rdma --web.listen-address=:8864 --collector.disable-defaults
curl localhost:8864/metrics
The results can be viewed below:
metrics.log
Additionally, the above tests were performed on a node without RDMA devices. The node-exporter runs without issues, as shown in the following logs: