Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add xBSD pipelines #3160

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

rexagod
Copy link
Contributor

@rexagod rexagod commented Oct 19, 2024

Run tests on the following GOOS, in addition to Linux:

  • OpenBSD
  • FreeBSD
  • NetBSD
  • Dragonfly
  • Solaris
  • Darwin

The patch also makes changes to the testing scripts and introduces a tools binary to facilitate accommodating for various GOOS OOTB.

Fixes #2883.

@rexagod rexagod changed the title chore: add BSD pipeline [WIP] chore: add BSD pipeline Oct 19, 2024
@rexagod rexagod force-pushed the bsd-pipeline branch 19 times, most recently from 8ce2847 to f2e7601 Compare October 20, 2024 00:00
@discordianfish
Copy link
Member

tests fail

@rexagod rexagod force-pushed the bsd-pipeline branch 9 times, most recently from 6c6bb6c to 17a424d Compare November 23, 2024 04:12
@rexagod rexagod force-pushed the bsd-pipeline branch 3 times, most recently from f6f302f to 42f3e4e Compare December 21, 2024 06:37
For integration tests.

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: support non-linux GOOS in e2e tests

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: support e2e tests on freebsd

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: support e2e tests on openbsd

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: support e2e tests on netbsd

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: support e2e tests on solaris

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: support e2e tests on dragonfly

Signed-off-by: Pranshu Srivastava <[email protected]>

chore: drop support for e2e tests on solaris

Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod rexagod force-pushed the bsd-pipeline branch 2 times, most recently from 3710f41 to 3e95361 Compare December 21, 2024 08:12
@rexagod
Copy link
Contributor Author

rexagod commented Dec 21, 2024

Working on adding support for Solaris as well, in addition to accommodating for any newly added metrics since the last time I patched this, to make sure the tests pass.

@rexagod rexagod force-pushed the bsd-pipeline branch 13 times, most recently from 9edc87b to c265b6d Compare December 22, 2024 07:57
Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
Copy link
Contributor Author

rexagod commented Dec 22, 2024

Good for reviews. I've also added Solaris and Darwin. I believe this completes support for all BSD platforms we target in this repository.

cc @discordianfish @SuperQ

Makefile.common Outdated Show resolved Hide resolved
@discordianfish
Copy link
Member

Beside that, this looks really great!

@rexagod
Copy link
Contributor Author

rexagod commented Dec 25, 2024

Dropped the changes for Makefile.common from this PR, so that we are not blocked by upstream. Also, this change is not required by GitHub's MacOS runners, so it's safe to merge this PR without that (all checks passing).

I'll pull the changes from upstream once they are merged there, but we can safely proceed independent of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build new *BSD CI pipelines
3 participants