netdev: Add ifAlias label #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvil
force-pushed
the
netdev_common_add_ifAlias_label
branch
from
d4241aa
to
a193625
Compare
SuperQ
requested changes
Aug 19, 2024
There was a problem hiding this comment.
This is a useful idea, but the implementation needs work.
First, any parsing of /sys needs to happen in https://github.com/prometheus/procfs.
Second, this needs to go in netdev_linux.go, not the common file. This would break on non-Linux builds.
|
@SuperQ thank you for your response, will fix that. As for the second part, do you want to create some common functions to construct labels and etc (something like |
|
@SuperQ I've updated the code. Please review once you're available. |
SuperQ
reviewed
Aug 26, 2024
tomvil
force-pushed
the
netdev_common_add_ifAlias_label
branch
2 times, most recently
from
7aff8e8
to
39fd82b
Compare
tomvil
force-pushed
the
netdev_common_add_ifAlias_label
branch
from
39fd82b
to
b6d513c
Compare
Signed-off-by: Tomas Vilemaitis <[email protected]>
tomvil
force-pushed
the
netdev_common_add_ifAlias_label
branch
from
b6d513c
to
40dce8f
Compare
|
ping @discordianfish 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very handy label to have. Adding it as a option, which can be enabled when needed, to avoid breaking working stuff.