zfs: tidy up Linux-specific code #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
approved these changes
Jul 14, 2024
|
Looks like this needs a rebase |
dswarbrick
force-pushed
the
zfs
branch
3 times, most recently
from
52bddb6
to
43aac5d
Compare
|
@SuperQ Rebased, PTAL. |
dswarbrick
force-pushed
the
zfs
branch
2 times, most recently
from
447cc10
to
93a4c03
Compare
|
Rebased, again, due to incoming log/slog migration. PTAL, A. |
|
CircleCI test failures appear to have been transient due to them having a bad day, but I not able to retry the job. |
Avoid Linux-specific code scattered in two places by moving it to the already-existing zfs_linux.go. Signed-off-by: Daniel Swarbrick <[email protected]>
Signed-off-by: Daniel Swarbrick <[email protected]>
Code does not modify zfsPoolStatesName slice, so make it an array. Signed-off-by: Daniel Swarbrick <[email protected]>
Ensure identical factory function name across arch-specific files so that the common init() function in zfs.go works. Signed-off-by: Daniel Swarbrick <[email protected]>
Also add build-tags to ensure it is ignored on non-relevant archs. Signed-off-by: Daniel Swarbrick <[email protected]>
Drop superfluous and overly pedantic typecasting for values that fit within 32 bits or where type comparison is already hinted. Signed-off-by: Daniel Swarbrick <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group all Linux-specific zfs collector code in the already-existing zfs_linux.go, and move arch-agnostic
init()function out of arch-specific files.