Add support for OpenTelemetry #995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
dhoard
force-pushed
the
otel-integration
branch
from
812fed2
to
721a3b0
Compare
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
… output Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
|
@dhoard that's a big pr - can you walk me through it on the next meeting or set up a call? |
Definitely. |
Signed-off-by: dhoard <[email protected]>
zeitlinger
reviewed
Nov 11, 2024
| ConfigurationException.supplier( | ||
| "Missing /openTelemetry configuration")); | ||
|
|
||
| String endpoint = |
There was a problem hiding this comment.
you can configure otel based on env vars only (since 1.3.2) - see https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/
I'm not sure if this already works with this PR.
Maybe it would be an idea to add otel: true or similar to make it obvious that those env vars should be used (since you'd have no otel config in the yaml)
| + " an integer greater than 0"))) | ||
| .orElse(NO_INTERVAL); | ||
|
|
||
| Map<String, String> headers = |
There was a problem hiding this comment.
would be good to support resource attributes the same way
jmx_prometheus_javaagent/src/test/java/io/prometheus/jmx/ArgumentsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Signed-off-by: dhoard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fstab please review.