Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align example-configs to naming changes of #852 #882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

s-rwe
Copy link

@s-rwe s-rwe commented Oct 23, 2023

A minor PR to have the example_configs make use of the updating naming, of #852

@dhoard for consideration

@s-rwe s-rwe force-pushed the update-naming-in-example-configs branch from 76f8658 to 6b1f660 Compare October 23, 2023 07:15
@dhoard
Copy link
Collaborator

dhoard commented Nov 3, 2023

@s-rwe Thanks for the PR!

I think this is a worthwhile change, but I'm concerned that a user will use an old JMX Exporter version with the new configuration files, which doesn't work.

I am working on integrating the new client_java 1.0.0 library, which could introduce some breaking changes around metrics names. If this is the case, I feel we should completely remove support for the configuration values whitelistObjectNames and blacklistObjectNames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants