add support for loading a customAuthenticator class #1001 - needs cli… #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needs client_java 1.4 Signed-off-by: Gary Tully <[email protected]>
|
Is there a branch where the snapshot versions are referenced? I have tweaked the pom.xml (which cannot correct) to have this work. thanks! |
|
The main branch build version is generic |
gtully
commented
Oct 3, 2024
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <prometheus.metrics.version>1.3.1</prometheus.metrics.version> | |||
| <prometheus.metrics.version>1.4.0-SNAPSHOT</prometheus.metrics.version> | |||
There was a problem hiding this comment.
@dhoard thanks, for this change, I guess there is no other option, the client_java project uses snapshots.
There was a problem hiding this comment.
@gtully to clarify, by design, the jmx_exporter project only uses client_java release artifacts. There is no snapshot dependency between the projects.
It does become cumbersome when there are dependencies, but it only occurs rarely.
There was a problem hiding this comment.
thanks, that makes sense, this will have to wait for prometheus/client_java#1088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent_java 1.4
requires prometheus/client_java#1088